]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Merge commit 'gcl/gcl-next' into next
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 13 Jan 2009 02:59:11 +0000 (13:59 +1100)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 13 Jan 2009 02:59:11 +0000 (13:59 +1100)
arch/powerpc/platforms/512x/clock.c
arch/powerpc/platforms/52xx/mpc52xx_gpio.c
arch/powerpc/platforms/52xx/mpc52xx_pic.c
drivers/block/xsysace.c
drivers/of/of_i2c.c
drivers/spi/xilinx_spi.c
include/linux/of_i2c.h

index f416014ee727b99813017554dd654e5495210053..1bcff94eb924b054575ac58aba4a6713c0a6d0f9 100644 (file)
@@ -56,12 +56,12 @@ static struct clk *mpc5121_clk_get(struct device *dev, const char *id)
        int dev_match = 0;
        int id_match = 0;
 
-       if (dev == NULL && id == NULL)
+       if (dev == NULL || id == NULL)
                return NULL;
 
        mutex_lock(&clocks_mutex);
        list_for_each_entry(p, &clocks, node) {
-               if (dev && dev == p->dev)
+               if (dev == p->dev)
                        dev_match++;
                if (strcmp(id, p->name) == 0)
                        id_match++;
index 8a455ebce98d16306eb8b926da3e1684ac406ba0..07f89ae46d04b1953bc9d1d45f6cce0cd5b844f0 100644 (file)
@@ -363,11 +363,8 @@ static int mpc52xx_gpt_gpio_get(struct gpio_chip *gc, unsigned int gpio)
 {
        struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
        struct mpc52xx_gpt __iomem *regs = mm_gc->regs;
-       unsigned int ret;
 
        return (in_be32(&regs->status) & (1 << (31 - 23))) ? 1 : 0;
-
-       return ret;
 }
 
 static void
index 72865e8e4b5124b1567c4546d9cee99e499311e8..0a093f03c75898ca6b4c1b4e7943d2dc7759819f 100644 (file)
@@ -196,6 +196,7 @@ static void mpc52xx_extirq_ack(unsigned int virq)
 
 static int mpc52xx_extirq_set_type(unsigned int virq, unsigned int flow_type)
 {
+       struct irq_desc *desc = get_irq_desc(virq);
        u32 ctrl_reg, type;
        int irq;
        int l2irq;
@@ -222,6 +223,11 @@ static int mpc52xx_extirq_set_type(unsigned int virq, unsigned int flow_type)
                type = 0;
        }
 
+       desc->status &= ~(IRQ_TYPE_SENSE_MASK | IRQ_LEVEL);
+       desc->status |= flow_type & IRQ_TYPE_SENSE_MASK;
+       if (flow_type & (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW))
+               desc->status |= IRQ_LEVEL;
+
        ctrl_reg = in_be32(&intr->ctrl);
        ctrl_reg &= ~(0x3 << (22 - (l2irq * 2)));
        ctrl_reg |= (type << (22 - (l2irq * 2)));
@@ -231,7 +237,7 @@ static int mpc52xx_extirq_set_type(unsigned int virq, unsigned int flow_type)
 }
 
 static struct irq_chip mpc52xx_extirq_irqchip = {
-       .typename = " MPC52xx IRQ[0-3] ",
+       .typename = "MPC52xx External",
        .mask = mpc52xx_extirq_mask,
        .unmask = mpc52xx_extirq_unmask,
        .ack = mpc52xx_extirq_ack,
index 29e1dfafb7c6bd813844b82f1e903f88e5d34d99..381d686fc1a3cdacba8a5ac38424440ea8dff925 100644 (file)
@@ -1206,6 +1206,7 @@ static struct of_device_id ace_of_match[] __devinitdata = {
        { .compatible = "xlnx,opb-sysace-1.00.b", },
        { .compatible = "xlnx,opb-sysace-1.00.c", },
        { .compatible = "xlnx,xps-sysace-1.00.a", },
+       { .compatible = "xlnx,sysace", },
        {},
 };
 MODULE_DEVICE_TABLE(of, ace_of_match);
index e1b0ad6e918f0bec0a843888e4de826d1cccf825..fa65a2b2ae2e44737edb5d4e19daf767e331bd9c 100644 (file)
@@ -66,4 +66,23 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
 }
 EXPORT_SYMBOL(of_register_i2c_devices);
 
+static int of_dev_node_match(struct device *dev, void *data)
+{
+        return dev_archdata_get_node(&dev->archdata) == data;
+}
+
+/* must call put_device() when done with returned i2c_client device */
+struct i2c_client *of_find_i2c_device_by_node(struct device_node *node)
+{
+       struct device *dev;
+
+       dev = bus_find_device(&i2c_bus_type, NULL, node,
+                                        of_dev_node_match);
+       if (!dev)
+               return NULL;
+
+       return to_i2c_client(dev);
+}
+EXPORT_SYMBOL(of_find_i2c_device_by_node);
+
 MODULE_LICENSE("GPL");
index 68d6f4988fb52a7aca99f5315697d6cb4ca6cf91..fe7e5f35e5d0393ccd04bac2993413ee2d26bf1a 100644 (file)
 #include <linux/init.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
+
+#include <linux/of_platform.h>
+#include <linux/of_device.h>
+#include <linux/of_spi.h>
+
 #include <linux/spi/spi.h>
 #include <linux/spi/spi_bitbang.h>
 #include <linux/io.h>
 
-#include <syslib/virtex_devices.h>
-
 #define XILINX_SPI_NAME "xilinx_spi"
 
 /* Register definitions as per "OPB Serial Peripheral Interface (SPI) (v1.00e)
@@ -144,23 +147,14 @@ static int xilinx_spi_setup_transfer(struct spi_device *spi,
                struct spi_transfer *t)
 {
        u8 bits_per_word;
-       u32 hz;
-       struct xilinx_spi *xspi = spi_master_get_devdata(spi->master);
 
        bits_per_word = (t) ? t->bits_per_word : spi->bits_per_word;
-       hz = (t) ? t->speed_hz : spi->max_speed_hz;
        if (bits_per_word != 8) {
                dev_err(&spi->dev, "%s, unsupported bits_per_word=%d\n",
                        __func__, bits_per_word);
                return -EINVAL;
        }
 
-       if (hz && xspi->speed_hz > hz) {
-               dev_err(&spi->dev, "%s, unsupported clock rate %uHz\n",
-                       __func__, hz);
-               return -EINVAL;
-       }
-
        return 0;
 }
 
@@ -304,32 +298,38 @@ static irqreturn_t xilinx_spi_irq(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static int __init xilinx_spi_probe(struct platform_device *dev)
+static int __init xilinx_spi_of_probe(struct of_device *ofdev,
+                                       const struct of_device_id *match)
 {
-       int ret = 0;
        struct spi_master *master;
        struct xilinx_spi *xspi;
-       struct xspi_platform_data *pdata;
-       struct resource *r;
+       struct resource r_irq_struct;
+       struct resource r_mem_struct;
+
+       struct resource *r_irq = &r_irq_struct;
+       struct resource *r_mem = &r_mem_struct;
+       int rc = 0;
+       const u32 *prop;
+       int len;
 
        /* Get resources(memory, IRQ) associated with the device */
-       master = spi_alloc_master(&dev->dev, sizeof(struct xilinx_spi));
+       master = spi_alloc_master(&ofdev->dev, sizeof(struct xilinx_spi));
 
        if (master == NULL) {
                return -ENOMEM;
        }
 
-       platform_set_drvdata(dev, master);
-       pdata = dev->dev.platform_data;
+       dev_set_drvdata(&ofdev->dev, master);
 
-       if (pdata == NULL) {
-               ret = -ENODEV;
+       rc = of_address_to_resource(ofdev->node, 0, r_mem);
+       if (rc) {
+               dev_warn(&ofdev->dev, "invalid address\n");
                goto put_master;
        }
 
-       r = platform_get_resource(dev, IORESOURCE_MEM, 0);
-       if (r == NULL) {
-               ret = -ENODEV;
+       rc = of_irq_to_resource(ofdev->node, 0, r_irq);
+       if (rc == NO_IRQ) {
+               dev_warn(&ofdev->dev, "no IRQ found\n");
                goto put_master;
        }
 
@@ -341,47 +341,57 @@ static int __init xilinx_spi_probe(struct platform_device *dev)
        xspi->bitbang.master->setup = xilinx_spi_setup;
        init_completion(&xspi->done);
 
-       if (!request_mem_region(r->start,
-                       r->end - r->start + 1, XILINX_SPI_NAME)) {
-               ret = -ENXIO;
+       xspi->irq = r_irq->start;
+
+       if (!request_mem_region(r_mem->start,
+                       r_mem->end - r_mem->start + 1, XILINX_SPI_NAME)) {
+               rc = -ENXIO;
+               dev_warn(&ofdev->dev, "memory request failure\n");
                goto put_master;
        }
 
-       xspi->regs = ioremap(r->start, r->end - r->start + 1);
+       xspi->regs = ioremap(r_mem->start, r_mem->end - r_mem->start + 1);
        if (xspi->regs == NULL) {
-               ret = -ENOMEM;
+               rc = -ENOMEM;
+               dev_warn(&ofdev->dev, "ioremap failure\n");
                goto put_master;
        }
+       xspi->irq = r_irq->start;
 
-       ret = platform_get_irq(dev, 0);
-       if (ret < 0) {
-               ret = -ENXIO;
-               goto unmap_io;
-       }
-       xspi->irq = ret;
+       /* dynamic bus assignment */
+       master->bus_num = -1;
 
-       master->bus_num = pdata->bus_num;
-       master->num_chipselect = pdata->num_chipselect;
-       xspi->speed_hz = pdata->speed_hz;
+       /* number of slave select bits is required */
+       prop = of_get_property(ofdev->node, "xlnx,num-ss-bits", &len);
+       if (!prop || len < sizeof(*prop)) {
+               dev_warn(&ofdev->dev, "no 'xlnx,num-ss-bits' property\n");
+               goto put_master;
+       }
+       master->num_chipselect = *prop;
 
        /* SPI controller initializations */
        xspi_init_hw(xspi->regs);
 
        /* Register for SPI Interrupt */
-       ret = request_irq(xspi->irq, xilinx_spi_irq, 0, XILINX_SPI_NAME, xspi);
-       if (ret != 0)
+       rc = request_irq(xspi->irq, xilinx_spi_irq, 0, XILINX_SPI_NAME, xspi);
+       if (rc != 0) {
+               dev_warn(&ofdev->dev, "irq request failure: %d\n", xspi->irq);
                goto unmap_io;
+       }
 
-       ret = spi_bitbang_start(&xspi->bitbang);
-       if (ret != 0) {
-               dev_err(&dev->dev, "spi_bitbang_start FAILED\n");
+       rc = spi_bitbang_start(&xspi->bitbang);
+       if (rc != 0) {
+               dev_err(&ofdev->dev, "spi_bitbang_start FAILED\n");
                goto free_irq;
        }
 
-       dev_info(&dev->dev, "at 0x%08X mapped to 0x%08X, irq=%d\n",
-                       r->start, (u32)xspi->regs, xspi->irq);
+       dev_info(&ofdev->dev, "at 0x%08X mapped to 0x%08X, irq=%d\n",
+                       (unsigned int)r_mem->start, (u32)xspi->regs, xspi->irq);
 
-       return ret;
+       /* Add any subnodes on the SPI bus */
+       of_register_spi_devices(master, ofdev->node);
+
+       return rc;
 
 free_irq:
        free_irq(xspi->irq, xspi);
@@ -389,21 +399,21 @@ unmap_io:
        iounmap(xspi->regs);
 put_master:
        spi_master_put(master);
-       return ret;
+       return rc;
 }
 
-static int __devexit xilinx_spi_remove(struct platform_device *dev)
+static int __devexit xilinx_spi_remove(struct of_device *ofdev)
 {
        struct xilinx_spi *xspi;
        struct spi_master *master;
 
-       master = platform_get_drvdata(dev);
+       master = platform_get_drvdata(ofdev);
        xspi = spi_master_get_devdata(master);
 
        spi_bitbang_stop(&xspi->bitbang);
        free_irq(xspi->irq, xspi);
        iounmap(xspi->regs);
-       platform_set_drvdata(dev, 0);
+       dev_set_drvdata(&ofdev->dev, 0);
        spi_master_put(xspi->bitbang.master);
 
        return 0;
@@ -412,27 +422,42 @@ static int __devexit xilinx_spi_remove(struct platform_device *dev)
 /* work with hotplug and coldplug */
 MODULE_ALIAS("platform:" XILINX_SPI_NAME);
 
-static struct platform_driver xilinx_spi_driver = {
-       .probe  = xilinx_spi_probe,
-       .remove = __devexit_p(xilinx_spi_remove),
+static int __exit xilinx_spi_of_remove(struct of_device *op)
+{
+       return xilinx_spi_remove(op);
+}
+
+static struct of_device_id xilinx_spi_of_match[] = {
+       { .compatible = "xlnx,xps-spi-2.00.a", },
+       { .compatible = "xlnx,xps-spi-2.00.b", },
+       {}
+};
+
+MODULE_DEVICE_TABLE(of, xilinx_spi_of_match);
+
+static struct of_platform_driver xilinx_spi_of_driver = {
+       .owner = THIS_MODULE,
+       .name = "xilinx-xps-spi",
+       .match_table = xilinx_spi_of_match,
+       .probe = xilinx_spi_of_probe,
+       .remove = __exit_p(xilinx_spi_of_remove),
        .driver = {
-               .name = XILINX_SPI_NAME,
+               .name = "xilinx-xps-spi",
                .owner = THIS_MODULE,
        },
 };
 
 static int __init xilinx_spi_init(void)
 {
-       return platform_driver_register(&xilinx_spi_driver);
+       return of_register_platform_driver(&xilinx_spi_of_driver);
 }
 module_init(xilinx_spi_init);
 
 static void __exit xilinx_spi_exit(void)
 {
-       platform_driver_unregister(&xilinx_spi_driver);
+       of_unregister_platform_driver(&xilinx_spi_of_driver);
 }
 module_exit(xilinx_spi_exit);
-
 MODULE_AUTHOR("MontaVista Software, Inc. <source@mvista.com>");
 MODULE_DESCRIPTION("Xilinx SPI driver");
 MODULE_LICENSE("GPL");
index bd2a870ec29621f54b4b53aea5dd15f8bb8c346f..34974b5a76f78d1d9d142c3df4fb0e23a0ba106e 100644 (file)
@@ -17,4 +17,7 @@
 void of_register_i2c_devices(struct i2c_adapter *adap,
                             struct device_node *adap_node);
 
+/* must call put_device() when done with returned i2c_client device */
+struct i2c_client *of_find_i2c_device_by_node(struct device_node *node);
+
 #endif /* __LINUX_OF_I2C_H */