]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon: (thmc50) Convert to use devm_ functions
authorGuenter Roeck <linux@roeck-us.net>
Sat, 2 Jun 2012 18:20:23 +0000 (11:20 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 22 Jul 2012 04:48:42 +0000 (21:48 -0700)
Convert to use devm_ functions to reduce code size and simplify the code.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/thmc50.c

index add9f019b24fdf39047f94b577e2fdec99821c53..080c2637048093e5924d6cc7042e08056c538408 100644 (file)
@@ -361,12 +361,10 @@ static int thmc50_probe(struct i2c_client *client,
        struct thmc50_data *data;
        int err;
 
-       data = kzalloc(sizeof(struct thmc50_data), GFP_KERNEL);
-       if (!data) {
-               pr_debug("thmc50: detect failed, kzalloc failed!\n");
-               err = -ENOMEM;
-               goto exit;
-       }
+       data = devm_kzalloc(&client->dev, sizeof(struct thmc50_data),
+                           GFP_KERNEL);
+       if (!data)
+               return -ENOMEM;
 
        i2c_set_clientdata(client, data);
        data->type = id->driver_data;
@@ -377,7 +375,7 @@ static int thmc50_probe(struct i2c_client *client,
        /* Register sysfs hooks */
        err = sysfs_create_group(&client->dev.kobj, &thmc50_group);
        if (err)
-               goto exit_free;
+               return err;
 
        /* Register ADM1022 sysfs hooks */
        if (data->has_temp3) {
@@ -400,9 +398,6 @@ exit_remove_sysfs:
                sysfs_remove_group(&client->dev.kobj, &temp3_group);
 exit_remove_sysfs_thmc50:
        sysfs_remove_group(&client->dev.kobj, &thmc50_group);
-exit_free:
-       kfree(data);
-exit:
        return err;
 }
 
@@ -415,8 +410,6 @@ static int thmc50_remove(struct i2c_client *client)
        if (data->has_temp3)
                sysfs_remove_group(&client->dev.kobj, &temp3_group);
 
-       kfree(data);
-
        return 0;
 }