]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Revert "drm/i915: Enable semaphores on BDW"
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 4 Aug 2014 18:15:19 +0000 (11:15 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 8 Aug 2014 14:22:19 +0000 (16:22 +0200)
This reverts commit 521e62e49a42661a4ee0102644517dbe2f100a23.

Although POST_SYNC brought a bit of stability to Semaphores on BDW
it didn't solved all issues and some hungs can still occour when
semaphores are enabled on BDW. Also some sloweness can be found on some
igt tests, althoguth it apparently doesn't affect real workloads.

Besides that, no real performance gain was found on our tests with different
and even multiple workloads.

Let's disable it again for now. At least until we are sure it is safe
to re-enable it.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.c

index 6c4b25ce8bb0bb5a591496fc45ed52a4849c1296..ec96f9a9724c809363cd2cd88baf2cd7a31b9a3e 100644 (file)
@@ -481,6 +481,10 @@ bool i915_semaphore_is_enabled(struct drm_device *dev)
        if (i915.semaphores >= 0)
                return i915.semaphores;
 
+       /* Until we get further testing... */
+       if (IS_GEN8(dev))
+               return false;
+
 #ifdef CONFIG_INTEL_IOMMU
        /* Enable semaphores on SNB when IO remapping is off */
        if (INTEL_INFO(dev)->gen == 6 && intel_iommu_gfx_mapped)