mfd: tps65010: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

This also start to propagate the negative error code from the
smbus call if there is one, as the last commit of this series
will make the gpiolib core deal with that properly.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c
index 448f0a182dc4562d19bb35f9952b96124dcd37d7..677a127619d4458b7c19760d357d80d39dd22a3e 100644 (file)
--- a/drivers/mfd/tps65010.c
+++ b/drivers/mfd/tps65010.c
@@ -499,11 +499,11 @@ static int tps65010_gpio_get(struct gpio_chip *chip, unsigned offset)
        if (offset < 4) {
                value = i2c_smbus_read_byte_data(tps->client, TPS_DEFGPIO);
                if (value < 0)
-                       return 0;
+                       return value;
                if (value & (1 << (offset + 4)))        /* output */
                        return !(value & (1 << offset));
                else                                    /* input */
-                       return (value & (1 << offset));
+                       return !!(value & (1 << offset));
        }
 
        /* REVISIT we *could* report LED1/nPG and LED2 state ... */