]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] em28xx-audio: provide an error code when URB submit fails
authorMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 14 Jan 2014 17:34:13 +0000 (14:34 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 14 Jan 2014 21:26:07 +0000 (19:26 -0200)
Instead of just saying:
[ 1646.412419] em2882/3 #0: submit of audio urb failed
Print the reason why it failed, to help debugging and fixing it.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/usb/em28xx/em28xx-audio.c

index 332abf7b32f818457899d8671aebb428f015f817..e57616ecd2cbba993004c587840ea2ce10e1c5a8 100644 (file)
@@ -163,10 +163,9 @@ static void em28xx_audio_isocirq(struct urb *urb)
        urb->status = 0;
 
        status = usb_submit_urb(urb, GFP_ATOMIC);
-       if (status < 0) {
+       if (status < 0)
                em28xx_errdev("resubmit of audio urb failed (error=%i)\n",
                              status);
-       }
        return;
 }
 
@@ -183,7 +182,8 @@ static int em28xx_init_audio_isoc(struct em28xx *dev)
 
                errCode = usb_submit_urb(dev->adev.urb[i], GFP_ATOMIC);
                if (errCode) {
-                       em28xx_errdev("submit of audio urb failed\n");
+                       em28xx_errdev("submit of audio urb failed (error=%i)\n",
+                                     errCode);
                        em28xx_deinit_isoc_audio(dev);
                        atomic_set(&dev->stream_started, 0);
                        return errCode;