]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ASoC: fsl_ssi: use flat regmap cache
authorMarek Vasut <marex@denx.de>
Mon, 19 Sep 2016 19:30:28 +0000 (21:30 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 20 Sep 2016 17:55:35 +0000 (18:55 +0100)
Same as commit ce492b3b8f99cf9d2f807ec22d8805c996a09503
Subject: drm/fsl-dcu: use flat regmap cache

Using flat regmap cache instead of RB-tree to avoid the following
lockdep warning on driver load:
WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2871 lockdep_trace_alloc+0x104/0x128
DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))

The RB-tree regmap cache needs to allocate new space on first
writes. However, allocations in an atomic context (e.g. when a
spinlock is held) are not allowed. The function regmap_write
calls map->lock, which acquires a spinlock in the fast_io case.
Since the driver uses MMIO, the regmap bus of type regmap_mmio
is being used which has fast_io set to true.

Signed-off-by: Marek Vasut <marex@denx.de>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_ssi.c

index bedec4a325813f92d752b16833ccfb0ba31b2db7..50349437d9615107a3a08fa481b6b2d61612e51c 100644 (file)
@@ -182,7 +182,7 @@ static const struct regmap_config fsl_ssi_regconfig = {
        .volatile_reg = fsl_ssi_volatile_reg,
        .precious_reg = fsl_ssi_precious_reg,
        .writeable_reg = fsl_ssi_writeable_reg,
-       .cache_type = REGCACHE_RBTREE,
+       .cache_type = REGCACHE_FLAT,
 };
 
 struct fsl_ssi_soc_data {