]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
cciss: remove unneeded memset()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 7 Sep 2012 00:17:58 +0000 (10:17 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 7 Sep 2012 05:36:07 +0000 (15:36 +1000)
The memory return by kzalloc() or kmem_cache_zalloc() has already be set
to zero, so remove useless memset(0).

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: Mike Miller <mike.miller@hp.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/block/cciss.c

index e04c63ec77592a38edc44beb4545bf69b980ffd3..6526157edafc151e2761adf740a6404a6c046f26 100644 (file)
@@ -5198,7 +5198,6 @@ static void cciss_shutdown(struct pci_dev *pdev)
                return;
        }
        /* write all data in the battery backed cache to disk */
-       memset(flush_buf, 0, 4);
        return_code = sendcmd_withirq(h, CCISS_CACHE_FLUSH, flush_buf,
                4, 0, CTLR_LUNID, TYPE_CMD);
        kfree(flush_buf);