drivers-firmware-dmi_scanc-fetch-dmi-version-from-smbios-if-it-exists-checkpatch...

WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
#56: FILE: drivers/firmware/dmi_scan.c:426:
+				printk(KERN_INFO "SMBIOS %d.%d present.\n",

WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
#61: FILE: drivers/firmware/dmi_scan.c:431:
+				printk(KERN_INFO "Legacy DMI %d.%d present.\n",

WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
#85: FILE: drivers/firmware/dmi_scan.c:455:
+			printk(KERN_DEBUG "SMBIOS version fixup(2.%d->2.%d)\n",

WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
#90: FILE: drivers/firmware/dmi_scan.c:460:
+			printk(KERN_DEBUG "SMBIOS version fixup(2.%d->2.%d)\n",

total: 0 errors, 4 warnings, 104 lines checked

./patches/drivers-firmware-dmi_scanc-fetch-dmi-version-from-smbios-if-it-exists.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Feng Jin <joe.jin@oracle.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 111f3bab3a320665164474a57464f49bca810659..fd3ae6290d71ecfd927cc4447a942c099bd223ea 100644 (file)
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -423,12 +423,12 @@ static int __init dmi_present(const char __iomem *p)
 
                if (dmi_walk_early(dmi_decode) == 0) {
                        if (dmi_ver)
-                               printk(KERN_INFO "SMBIOS %d.%d present.\n",
+                               pr_info("SMBIOS %d.%d present.\n",
                                       dmi_ver >> 8, dmi_ver & 0xFF);
                        else {
                                dmi_ver = (buf[14] & 0xF0) << 4 |
                                           (buf[14] & 0x0F);
-                               printk(KERN_INFO "Legacy DMI %d.%d present.\n",
+                               pr_info("Legacy DMI %d.%d present.\n",
                                       dmi_ver >> 8, dmi_ver & 0xFF);
                        }
                        dmi_dump_ids();
@@ -452,13 +452,12 @@ static int __init smbios_present(const char __iomem *p)
                switch (dmi_ver) {
                case 0x021F:
                case 0x0221:
-                       printk(KERN_DEBUG "SMBIOS version fixup(2.%d->2.%d)\n",
+                       pr_debug("SMBIOS version fixup(2.%d->2.%d)\n",
                               dmi_ver & 0xFF, 3);
                        dmi_ver = 0x0203;
                        break;
                case 0x0233:
-                       printk(KERN_DEBUG "SMBIOS version fixup(2.%d->2.%d)\n",
-                              51, 6);
+                       pr_debug("SMBIOS version fixup(2.%d->2.%d)\n", 51, 6);
                        dmi_ver = 0x0206;
                        break;
                }