]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
extcon: max77843: fix handling return value of regmap_irq_get_virq
authorAndrzej Hajda <a.hajda@samsung.com>
Mon, 14 Dec 2015 10:06:03 +0000 (11:06 +0100)
committerChanwoo Choi <cw00.choi@samsung.com>
Tue, 15 Dec 2015 01:02:34 +0000 (10:02 +0900)
The function can return negative values, so its result should
be assigned to signed variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-max77843.c

index 9f9ea334399c19044908f2ebe241e79166123fa5..74dfb7f4f2774c5c87e4e14a39db3e84ecbf8191 100644 (file)
@@ -811,7 +811,7 @@ static int max77843_muic_probe(struct platform_device *pdev)
 
        for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) {
                struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i];
-               unsigned int virq = 0;
+               int virq = 0;
 
                virq = regmap_irq_get_virq(max77843->irq_data_muic,
                                muic_irq->irq);