]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Staging: rtl8723au: Remove print statements and debug messages
authorBhumika Goyal <bhumirks@gmail.com>
Sun, 28 Feb 2016 17:25:29 +0000 (22:55 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
The  memory allocation functions generates a call stack containing
all the context information on failure, so print statements and debug
messages can be removed on failure of these functions. Also remove
unwanted {} around if block after removal of these messages.
Done using coccinelle:

@@
expression e;
@@

e=\(kmalloc\|kmalloc\|kmalloc_array\|alloc_netdev\|kzalloc\|
   devm_kzalloc\|devm_ioremap\)(...);
...
if(!e){
- \(DBG_8723A\|printk\|pr_err\|CERROR\|DBG_88E\)(...);
...when any
}

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/hal/usb_ops_linux.c
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

index 371e6b373420c18a950828c9e14b4fa87b59d467..5c81ff48252efd13c48a7af0f9c520f2668c5f46 100644 (file)
@@ -256,12 +256,8 @@ static void usb_read_interrupt_complete(struct urb *purb)
                                c2w = kmalloc(sizeof(struct evt_work),
                                                GFP_ATOMIC);
 
-                               if (!c2w) {
-                                       printk(KERN_WARNING "%s: unable to "
-                                              "allocate work buffer\n",
-                                              __func__);
+                               if (!c2w)
                                        goto urb_submit;
-                               }
 
                                c2w->adapter = padapter;
                                INIT_WORK(&c2w->work, rtw_evt_work);
index e64b7e14341ed7f59b98dc16cd24ea63c62edff7..12d18440e82448a354fb98760cf4a2383cc34f7c 100644 (file)
@@ -2610,8 +2610,6 @@ static int rtw_cfg80211_add_monitor_if(struct rtw_adapter *padapter, char *name,
        /*  wdev */
        mon_wdev = kzalloc(sizeof(struct wireless_dev), GFP_KERNEL);
        if (!mon_wdev) {
-               DBG_8723A("%s(%s): allocate mon_wdev fail\n", __func__,
-                         padapter->pnetdev->name);
                ret = -ENOMEM;
                goto out;
        }
@@ -3262,7 +3260,6 @@ int rtw_wdev_alloc(struct rtw_adapter *padapter, struct device *dev)
        /*  wdev */
        wdev = kzalloc(sizeof(struct wireless_dev), GFP_KERNEL);
        if (!wdev) {
-               DBG_8723A("Couldn't allocate wireless device\n");
                ret = -ENOMEM;
                goto free_wiphy;
        }