]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
mmc: slot-gpio: Don't override con_id when request descriptor
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 2 Jan 2017 12:05:25 +0000 (14:05 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 13 Feb 2017 12:20:06 +0000 (13:20 +0100)
The caller may supply connection ID, index, or both. All combinations are
possible and mmc framework should not make any assumption on what exactly
caller wants.

Remove con_id override conditionals in mmc_gpiod_request_ro() and
mmc_gpiod_request_cd().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/slot-gpio.c

index babe591aea969204bb9500e6c30ff1e64bdafd81..a8450a8701e435c8ae0878896fc6e5321626911e 100644 (file)
@@ -235,9 +235,6 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const char *con_id,
        struct gpio_desc *desc;
        int ret;
 
-       if (!con_id)
-               con_id = ctx->cd_label;
-
        desc = devm_gpiod_get_index(host->parent, con_id, idx, GPIOD_IN);
        if (IS_ERR(desc))
                return PTR_ERR(desc);
@@ -289,9 +286,6 @@ int mmc_gpiod_request_ro(struct mmc_host *host, const char *con_id,
        struct gpio_desc *desc;
        int ret;
 
-       if (!con_id)
-               con_id = ctx->ro_label;
-
        desc = devm_gpiod_get_index(host->parent, con_id, idx, GPIOD_IN);
        if (IS_ERR(desc))
                return PTR_ERR(desc);