]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
platform/x86: fujitsu-laptop: simplify acpi_bus_register_driver() error handling
authorAlan Jenkins <alan-jenkins@tuffmail.co.uk>
Wed, 8 Feb 2017 13:46:30 +0000 (14:46 +0100)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Sun, 26 Feb 2017 15:01:07 +0000 (17:01 +0200)
A separate variable is not needed to handle error codes returned by
acpi_bus_register_driver().  If the latter fails, just use the value it
returned as the value returned by fujitsu_init().

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
[kempniu: rebase patch, rewrite commit message]
Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
drivers/platform/x86/fujitsu-laptop.c

index ba0c0c21125102e25af216633077abcaf7451893..a5478a011b9068bf90f1bf901d39f4d64044e343 100644 (file)
@@ -1192,7 +1192,7 @@ MODULE_DEVICE_TABLE(acpi, fujitsu_ids);
 
 static int __init fujitsu_init(void)
 {
-       int ret, result, max_brightness;
+       int ret, max_brightness;
 
        if (acpi_disabled)
                return -ENODEV;
@@ -1207,11 +1207,9 @@ static int __init fujitsu_init(void)
        fujitsu_bl->keycode5 = KEY_RFKILL;
        dmi_check_system(fujitsu_dmi_table);
 
-       result = acpi_bus_register_driver(&acpi_fujitsu_bl_driver);
-       if (result < 0) {
-               ret = -ENODEV;
+       ret = acpi_bus_register_driver(&acpi_fujitsu_bl_driver);
+       if (ret)
                goto fail_acpi;
-       }
 
        /* Register platform stuff */
 
@@ -1264,11 +1262,9 @@ static int __init fujitsu_init(void)
                goto fail_laptop;
        }
 
-       result = acpi_bus_register_driver(&acpi_fujitsu_laptop_driver);
-       if (result < 0) {
-               ret = -ENODEV;
+       ret = acpi_bus_register_driver(&acpi_fujitsu_laptop_driver);
+       if (ret)
                goto fail_laptop1;
-       }
 
        /* Sync backlight power status (needs FUJ02E3 device, hence deferred) */
        if (acpi_video_get_backlight_type() == acpi_backlight_vendor) {