]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
dell-laptop - using buffer without mutex_lock
authorJose Alonso <joalonsof@gmail.com>
Sun, 10 Jul 2011 18:46:51 +0000 (15:46 -0300)
committerMatthew Garrett <mjg@redhat.com>
Mon, 11 Jul 2011 13:45:15 +0000 (09:45 -0400)
Using buffer->output[1] without mutex_lock()

Signed-off-by: Jose Alonso <joalonsof@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/dell-laptop.c

index 1b99152a4eb9461acd88fa624983cefef556ecc1..f31fa4efa725504bc4a9e6b251686453d0cb7e6d 100644 (file)
@@ -540,11 +540,11 @@ static int dell_get_intensity(struct backlight_device *bd)
        else
                dell_send_request(buffer, 0, 1);
 
+       ret = buffer->output[1];
+
 out:
        release_buffer();
-       if (ret)
-               return ret;
-       return buffer->output[1];
+       return ret;
 }
 
 static const struct backlight_ops dell_ops = {