]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
frv: Add missing RCU idle APIs on idle loop
authorFrederic Weisbecker <fweisbec@gmail.com>
Wed, 22 Aug 2012 15:27:34 +0000 (17:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Oct 2012 20:38:54 +0000 (05:38 +0900)
commit 41d8fe5bb3cf91ce2716ac8f43e4b40d802a99c8 upstream.

In the old times, the whole idle task was considered
as an RCU quiescent state. But as RCU became more and
more successful overtime, some RCU read side critical
section have been added even in the code of some
architectures idle tasks, for tracing for example.

So nowadays, rcu_idle_enter() and rcu_idle_exit() must
be called by the architecture to tell RCU about the part
in the idle loop that doesn't make use of rcu read side
critical sections, typically the part that puts the CPU
in low power mode.

This is necessary for RCU to find the quiescent states in
idle in order to complete grace periods.

Add this missing pair of calls in the Frv's idle loop.

Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: David Howells <dhowells@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/frv/kernel/process.c

index d4de48bd5efe4211990ec7530e25ad95e97819ad..3941cbc91ff60fd0680fb84df93d3f3c476e2e38 100644 (file)
@@ -25,6 +25,7 @@
 #include <linux/reboot.h>
 #include <linux/interrupt.h>
 #include <linux/pagemap.h>
+#include <linux/rcupdate.h>
 
 #include <asm/asm-offsets.h>
 #include <asm/uaccess.h>
@@ -84,12 +85,14 @@ void cpu_idle(void)
 {
        /* endless idle loop with no priority at all */
        while (1) {
+               rcu_idle_enter();
                while (!need_resched()) {
                        check_pgt_cache();
 
                        if (!frv_dma_inprogress && idle)
                                idle();
                }
+               rcu_idle_exit();
 
                schedule_preempt_disabled();
        }