]> git.karo-electronics.de Git - linux-beck.git/commitdiff
HSI: omap_ssi_port: Fix return value check in ssi_debug_add_port()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Wed, 30 Jul 2014 00:53:20 +0000 (08:53 +0800)
committerSebastian Reichel <sre@kernel.org>
Wed, 30 Jul 2014 22:20:21 +0000 (00:20 +0200)
In case of error, the function debugfs_create_*() returns NULL
pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test
in the return value check should be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/hsi/controllers/omap_ssi_port.c

index 001b8682061668621cbccfeaff0d38d2eb1a8621..4c0b5820581eaaba38e3f846454be8bdd75f3ccb 100644 (file)
@@ -177,13 +177,13 @@ static int __init ssi_debug_add_port(struct omap_ssi_port *omap_port,
        struct hsi_port *port = to_hsi_port(omap_port->dev);
 
        dir = debugfs_create_dir(dev_name(omap_port->dev), dir);
-       if (IS_ERR(dir))
-               return PTR_ERR(dir);
+       if (!dir)
+               return -ENOMEM;
        omap_port->dir = dir;
        debugfs_create_file("regs", S_IRUGO, dir, port, &ssi_port_regs_fops);
        dir = debugfs_create_dir("sst", dir);
-       if (IS_ERR(dir))
-               return PTR_ERR(dir);
+       if (!dir)
+               return -ENOMEM;
        debugfs_create_file("divisor", S_IRUGO | S_IWUSR, dir, port,
                            &ssi_sst_div_fops);