]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] pulse8-cec: fix compiler warning
authorHans Verkuil <hans.verkuil@cisco.com>
Sun, 11 Sep 2016 08:57:30 +0000 (05:57 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 12 Sep 2016 09:42:44 +0000 (06:42 -0300)
pulse8-cec.c: In function 'pulse8_connect':
pulse8-cec.c:447:2: warning: 'pa' may be used uninitialized in this function [-Wmaybe-uninitialized]
  cec_s_phys_addr(pulse8->adap, pa, false);
  ^
pulse8-cec.c:609:6: note: 'pa' was declared here
  u16 pa;
      ^

As far as I can tell, this can't actually happen. Still, it is better to just
initialize it.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/pulse8-cec/pulse8-cec.c

index cb6a2a3dcc68c759eab1b2eb7a1e0e7d7a8b5588..13e8f61c0a34a68ae746c9d959a47fb83b216251 100644 (file)
@@ -606,7 +606,7 @@ static int pulse8_connect(struct serio *serio, struct serio_driver *drv)
        struct pulse8 *pulse8;
        int err = -ENOMEM;
        struct cec_log_addrs log_addrs = {};
-       u16 pa;
+       u16 pa = CEC_PHYS_ADDR_INVALID;
 
        pulse8 = kzalloc(sizeof(*pulse8), GFP_KERNEL);