]> git.karo-electronics.de Git - linux-beck.git/commitdiff
power/reset: at91-reset: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 18 Nov 2015 22:04:14 +0000 (23:04 +0100)
committerSebastian Reichel <sre@kernel.org>
Sat, 5 Dec 2015 01:06:49 +0000 (02:06 +0100)
for_each_matching_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression e,e1;
local idexpression np;
@@

 for_each_matching_node(np, e1) {
   ... when != of_node_put(np)
       when != e = np
(
   return np;
|
+  of_node_put(np);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/reset/at91-reset.c

index 3f6b5dd7c3d4e47041611b3e6baab483c2ae41db..1b5d450586d18ae6e759407213030a16a82b7fef 100644 (file)
@@ -198,6 +198,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
                        at91_ramc_base[idx] = of_iomap(np, 0);
                        if (!at91_ramc_base[idx]) {
                                dev_err(&pdev->dev, "Could not map ram controller address\n");
+                               of_node_put(np);
                                return -ENODEV;
                        }
                        idx++;