]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
pstore: Replace calls to kmalloc and memcpy with kmemdup
authorAlexandru Gheorghiu <gheorghiuandru@gmail.com>
Sat, 9 Mar 2013 11:57:28 +0000 (13:57 +0200)
committerAnton Vorontsov <anton@enomsg.org>
Tue, 19 Mar 2013 02:38:26 +0000 (19:38 -0700)
Replaced calls to kmalloc and memcpy with a single call to kmemdup. This
patch was found using coccicheck.

Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
fs/pstore/ram.c

index 288f068740f6f6e2eb02dea57ed9a5ab1a8b47b8..38babb3a9384769e6373dee5ad069febb846f451 100644 (file)
@@ -156,10 +156,9 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type,
        time->tv_nsec = 0;
 
        size = persistent_ram_old_size(prz);
-       *buf = kmalloc(size, GFP_KERNEL);
+       *buf = kmemdup(persistent_ram_old(prz), size, GFP_KERNEL);
        if (*buf == NULL)
                return -ENOMEM;
-       memcpy(*buf, persistent_ram_old(prz), size);
 
        return size;
 }