]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[SCSI] scsi_debug: fix duplicate dif_errors increment
authorAkinobu Mita <akinobu.mita@gmail.com>
Wed, 26 Feb 2014 13:57:00 +0000 (22:57 +0900)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 19 Mar 2014 18:42:52 +0000 (11:42 -0700)
It is unnecessary to increase dif_errors in dif_verify(), because the
caller will increment it when dif_verify() detects failure.

This bug was introduced by commit beb40ea42bd6 ("[SCSI] scsi_debug:
reduce duplication between prot_verify_read and prot_verify_write")

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_debug.c

index 9cd211ea471968cab8a5b95b894a7c06c44cd1f3..1a4288032110ee332db5f2eac4ac5e94a0f1d8ea 100644 (file)
@@ -1780,7 +1780,6 @@ static int dif_verify(struct sd_dif_tuple *sdt, const void *data,
            be32_to_cpu(sdt->ref_tag) != ei_lba) {
                pr_err("%s: REF check failed on sector %lu\n",
                        __func__, (unsigned long)sector);
-                       dif_errors++;
                return 0x03;
        }
        return 0;