]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
b43legacy: Fix error due to MMIO access with SSB unpowered
authorLarry Finger <Larry.Finger@lwfinger.net>
Sun, 6 May 2012 21:01:05 +0000 (16:01 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Jun 2012 07:15:50 +0000 (15:15 +0800)
commit 8f4b20388fa77226a3605627a33a23f90d559e50 upstream.

There is a dummy read of a PCI MMIO register that occurs before the SSB bus
has been powered, which is an error. This bug has not been seen earlier,
but was apparently exposed when udev was updated to version 182.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/b43legacy/main.c

index 75e70bce40f6b8eb896ebb348e24c0f32a4b1930..2609cbe6d6ff8e9fb2b70a5ddb11c63192699abd 100644 (file)
@@ -1564,8 +1564,6 @@ static int b43legacy_request_firmware(struct b43legacy_wldev *dev)
        const char *filename;
        int err;
 
-       /* do dummy read */
-       ssb_read32(dev->dev, SSB_TMSHIGH);
        if (!fw->ucode) {
                if (rev == 2)
                        filename = "ucode2";