]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: vt6655: device_free_info() warn: variable dereferenced before check
authorMalcolm Priestley <tvboxspy@gmail.com>
Thu, 4 Sep 2014 22:08:36 +0000 (23:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Sep 2014 21:01:17 +0000 (14:01 -0700)
pDevice is never NULL when this function is called remove the check.

This fixes smatch warning
drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced
before check 'pDevice' (see line 1021)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@01.org
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/device_main.c

index f33795faa09ba7b6c6f4b67ea833a252c2ce6edb..7e7d9affbc122797449a209f9f5675121b7b90e9 100644 (file)
@@ -1008,9 +1008,6 @@ static void device_free_info(struct vnt_private *pDevice)
 {
        struct net_device *dev = pDevice->dev;
 
-       if (!pDevice)
-               return;
-
        ASSERT(pDevice);
 //2008-0714-01<Add>by chester
        device_release_WPADEV(pDevice);