ASoC: Fix a memory leak in alc5623_i2c_probe error path

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

diff --git a/sound/soc/codecs/alc5623.c b/sound/soc/codecs/alc5623.c
index e84b26b0ce9eb167acaf1c7f24ccbbda75a5c161..9783e7e2eb93ae1612da71a99a53537e861a6c8e 100644 (file)
--- a/sound/soc/codecs/alc5623.c
+++ b/sound/soc/codecs/alc5623.c
@@ -1022,10 +1022,8 @@ static int alc5623_i2c_probe(struct i2c_client *client,
        dev_dbg(&client->dev, "Found codec id : alc56%02x\n", vid2);
 
        alc5623 = kzalloc(sizeof(struct alc5623_priv), GFP_KERNEL);
-       if (alc5623 == NULL) {
-               ret = -ENOMEM;
-               goto err;
-       }
+       if (alc5623 == NULL)
+               return -ENOMEM;
 
        pdata = client->dev.platform_data;
        if (pdata) {
@@ -1056,12 +1054,9 @@ static int alc5623_i2c_probe(struct i2c_client *client,
                &soc_codec_device_alc5623, &alc5623_dai, 1);
        if (ret != 0) {
                dev_err(&client->dev, "Failed to register codec: %d\n", ret);
-               goto err;
+               kfree(alc5623);
        }
 
-       return 0;
-
-err:
        return ret;
 }