pinctrl: a minor error checking improvement for pinconf

Also checking invalid num_configs when validate the pinconf map.

Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 7ce139ef7e64b39d64518d164f20de80442b857c..43f474cdc11082717c881b757c6bcaf104bcbb97 100644 (file)
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -50,9 +50,9 @@ int pinconf_validate_map(struct pinctrl_map const *map, int i)
                return -EINVAL;
        }
 
-       if (map->data.configs.num_configs &&
+       if (!map->data.configs.num_configs ||
                        !map->data.configs.configs) {
-               pr_err("failed to register map %s (%d): no configs ptr given\n",
+               pr_err("failed to register map %s (%d): no configs given\n",
                       map->name, i);
                return -EINVAL;
        }