]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
vsprintf-correctly-handle-width-when-flag-used-in-%p-format-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Wed, 25 Apr 2012 01:03:55 +0000 (11:03 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 30 Apr 2012 05:17:30 +0000 (15:17 +1000)
ERROR: "(foo*)" should be "(foo *)"
#20: FILE: lib/vsprintf.c:869:
+ int default_width = 2 * sizeof(void*) + (spec.flags & SPECIAL ? 2 : 0);

total: 1 errors, 0 warnings, 32 lines checked

./patches/vsprintf-correctly-handle-width-when-flag-used-in-%p-format.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/vsprintf.c

index 1043827c3583a7eaebe42518a5fcb72ec544e46a..4e4f3b9e022a55423c75c83996ec07e16de05417 100644 (file)
@@ -866,7 +866,7 @@ static noinline_for_stack
 char *pointer(const char *fmt, char *buf, char *end, void *ptr,
              struct printf_spec spec)
 {
-       int default_width = 2 * sizeof(void*) + (spec.flags & SPECIAL ? 2 : 0);
+       int default_width = 2 * sizeof(void *) + (spec.flags & SPECIAL ? 2 : 0);
 
        if (!ptr && *fmt != 'K') {
                /*