]> git.karo-electronics.de Git - linux-beck.git/commitdiff
thermal: cpu_cooling: Don't check is_cpufreq_valid()
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 4 Dec 2014 04:11:57 +0000 (09:41 +0530)
committerEduardo Valentin <edubezval@gmail.com>
Mon, 8 Dec 2014 16:08:57 +0000 (12:08 -0400)
Because get_cpu_frequency() has returned a valid frequency, it means that the
cpufreq policy is surely valid and so no point checking that again with
is_cpufreq_valid(). Get rid of the routine as well as there are no more users.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/cpu_cooling.c

index 7f27f1b447766f75e60183188b08b94d3710444c..1dd4cc403a2a0a4e5595d7353569f3595dd15256 100644 (file)
@@ -110,23 +110,6 @@ static void release_idr(struct idr *idr, int id)
 
 /* Below code defines functions to be used for cpufreq as cooling device */
 
-/**
- * is_cpufreq_valid - function to check frequency transitioning capability.
- * @cpu: cpu for which check is needed.
- *
- * This function will check the current state of the system if
- * it is capable of changing the frequency for a given @cpu.
- *
- * Return: 0 if the system is not currently capable of changing
- * the frequency of given cpu. !0 in case the frequency is changeable.
- */
-static int is_cpufreq_valid(int cpu)
-{
-       struct cpufreq_policy policy;
-
-       return !cpufreq_get_policy(&policy, cpu);
-}
-
 enum cpufreq_cooling_property {
        GET_LEVEL,
        GET_FREQ,
@@ -300,8 +283,7 @@ static int cpufreq_apply_cooling(struct cpufreq_cooling_device *cpufreq_device,
        cpufreq_device->cpufreq_state = cooling_state;
        cpufreq_device->cpufreq_val = clip_freq;
 
-       if (is_cpufreq_valid(cpu))
-               cpufreq_update_policy(cpu);
+       cpufreq_update_policy(cpu);
 
        return 0;
 }