]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
kernel-watchdogc-print-traces-for-all-cpus-on-lockup-detection-fix-2
authorJan Moskyto Matejka <mq@suse.cz>
Sat, 17 May 2014 13:19:22 +0000 (23:19 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 20 May 2014 08:14:09 +0000 (18:14 +1000)
This commit fixes this warning:

kernel/watchdog.c: In function `watchdog_timer_fn':
kernel/watchdog.c:368:4: warning: `smp_mb__after_clear_bit' is deprecated (declared at include/linux/bitops.h:48) [-Wdeprecated-declarations]
    smp_mb__after_clear_bit();

That code was introduced in commit 90e6b763ca8a5eb739e59489f42d45e13431d157
("kernel/watchdog.c: print traces for all cpus on lockup detection") and then
merged with another branch containing commit
febdbfe8a91ce0d11939d4940b592eb0dba8d663 ("arch: Prepare for
smp_mb__{before,after}_atomic()") which deprecates the
smp_mb__after_clear_bit() call in favour of smp_mb__after_atomic().

Signed-off-by: Jan Moskyto Matejka <mq@suse.cz>
Acked-by: Aaron Tomlin <atomlin@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/watchdog.c

index bd77e97963a37b97c7cecd7e7881098e428b75cb..65f1adcade53e84931bba579a2a5de792629d26c 100644 (file)
@@ -363,7 +363,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
 
                        clear_bit(0, &soft_lockup_nmi_warn);
                        /* Barrier to sync with other cpus */
-                       smp_mb__after_clear_bit();
+                       smp_mb__after_atomic();
                }
 
                if (softlockup_panic)