]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: lustre: lnet: fix type warning in lib-socket.c
authorWilliam Blough <devel@blough.us>
Sun, 12 Feb 2017 10:05:31 +0000 (05:05 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 12 Feb 2017 12:13:06 +0000 (13:13 +0100)
The local socket address is defined as a __be32 value.  However, if the
local ip address is not given, then the constant INADDR_ANY is used.

This patch converts INADDR_ANY to __be32 for type consistency.

Fixes the following sparse warnings:

drivers/staging/lustre/lnet/lnet/lib-socket.c:396:41: warning:
 incorrect type in assignment (different base types)
drivers/staging/lustre/lnet/lnet/lib-socket.c:397:56: warning:
 restricted __be32 degrades to integer

Signed-off-by: William Blough <devel@blough.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lnet/lnet/lib-socket.c

index 654a7b2621884320d399b99af65fd2769f2756f6..b7b87ecefcdfc712b74a79298594cdaa94ab68bc 100644 (file)
@@ -393,8 +393,10 @@ lnet_sock_create(struct socket **sockp, int *fatal, __u32 local_ip,
                memset(&locaddr, 0, sizeof(locaddr));
                locaddr.sin_family = AF_INET;
                locaddr.sin_port = htons(local_port);
-               locaddr.sin_addr.s_addr = !local_ip ?
-                                         INADDR_ANY : htonl(local_ip);
+               if (!local_ip)
+                       locaddr.sin_addr.s_addr = htonl(INADDR_ANY);
+               else
+                       locaddr.sin_addr.s_addr = htonl(local_ip);
 
                rc = kernel_bind(sock, (struct sockaddr *)&locaddr,
                                 sizeof(locaddr));