]> git.karo-electronics.de Git - linux-beck.git/commitdiff
usb: dwc3: clean TRB if STARTTRANSFER fail
authorJanusz Dziedzic <januszx.dziedzic@linux.intel.com>
Wed, 9 Nov 2016 10:01:32 +0000 (11:01 +0100)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Fri, 18 Nov 2016 11:54:14 +0000 (13:54 +0200)
In case STARTTRANSFER will fail, clean TRB.
Seems HW in such case don't clean HWO bit.
So, without this cleanup prev_trb still have
HWO bit set.

In my case (without patch), after first START failed:
- dep->enqueue == 1
- dep->dequeue == 1
- prev_trb still have HWO set
- left_trb() == 0
No way to send more data.

Signed-off-by: Janusz Dziedzic <januszx.dziedzic@linux.intel.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/gadget.c

index 9d6c085c6d48354eec15e2df441e395b33598b83..9262ef20f7c6bf274cf0794874d3888acd43ee62 100644 (file)
@@ -1084,6 +1084,8 @@ static int __dwc3_gadget_kick_transfer(struct dwc3_ep *dep, u16 cmd_param)
                 * here and stop, unmap, free and del each of the linked
                 * requests instead of what we do now.
                 */
+               if (req->trb)
+                       memset(req->trb, 0, sizeof(struct dwc3_trb));
                dep->queued_requests--;
                dwc3_gadget_giveback(dep, req, ret);
                return ret;