]> git.karo-electronics.de Git - linux-beck.git/commitdiff
ASoC: wm8731: Use the preferred form for passing a size of a struct
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 24 Oct 2014 15:01:27 +0000 (13:01 -0200)
committerMark Brown <broonie@kernel.org>
Tue, 28 Oct 2014 00:44:30 +0000 (00:44 +0000)
According to Documentation/CodingStyle - Chapter 14:

"The preferred form for passing a size of a struct is the following:

p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."

So do it as recommeded.

Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8731.c

index eebb3280bfad8870035af93bd1079498d1cdeec5..2c9f2a7005c35c51c5a724762877c320454dbb89 100644 (file)
@@ -680,8 +680,7 @@ static int wm8731_spi_probe(struct spi_device *spi)
        struct wm8731_priv *wm8731;
        int ret;
 
-       wm8731 = devm_kzalloc(&spi->dev, sizeof(struct wm8731_priv),
-                             GFP_KERNEL);
+       wm8731 = devm_kzalloc(&spi->dev, sizeof(*wm8731), GFP_KERNEL);
        if (wm8731 == NULL)
                return -ENOMEM;