]> git.karo-electronics.de Git - linux-beck.git/commitdiff
regulator: ti-abb: simplify platform_get_resource_byname/devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 19 Aug 2013 08:51:55 +0000 (10:51 +0200)
committerMark Brown <broonie@linaro.org>
Thu, 22 Aug 2013 10:15:00 +0000 (11:15 +0100)
Remove unneeded error handling on the result of a call to
platform_get_resource_byname when the value is passed to devm_ioremap_resource.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,e,e1;
expression ret != 0;
identifier l;
@@

  res = platform_get_resource_byname(...);
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/ti-abb-regulator.c

index 3753ed05e71920085c8bbff804a8728b037c7e72..d8e3e1262bc2960b4eebf89b5c552ef6e04df305 100644 (file)
@@ -717,11 +717,6 @@ static int ti_abb_probe(struct platform_device *pdev)
        /* Map ABB resources */
        pname = "base-address";
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
-       if (!res) {
-               dev_err(dev, "Missing '%s' IO resource\n", pname);
-               ret = -ENODEV;
-               goto err;
-       }
        abb->base = devm_ioremap_resource(dev, res);
        if (IS_ERR(abb->base)) {
                ret = PTR_ERR(abb->base);
@@ -770,11 +765,6 @@ static int ti_abb_probe(struct platform_device *pdev)
 
        pname = "ldo-address";
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
-       if (!res) {
-               dev_dbg(dev, "Missing '%s' IO resource\n", pname);
-               ret = -ENODEV;
-               goto skip_opt;
-       }
        abb->ldo_base = devm_ioremap_resource(dev, res);
        if (IS_ERR(abb->ldo_base)) {
                ret = PTR_ERR(abb->ldo_base);