]> git.karo-electronics.de Git - linux-beck.git/commitdiff
ste_dma40: Use kmalloc_array() in d40_lcla_allocate()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 16 Sep 2016 15:56:07 +0000 (17:56 +0200)
committerVinod Koul <vinod.koul@intel.com>
Mon, 26 Sep 2016 17:36:16 +0000 (23:06 +0530)
* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/ste_dma40.c

index 8b18e44a02d51438809216a6d1b16e002d60fbde..156199d168bfa6c93f4ef6a47111ff2a6aee7a84 100644 (file)
@@ -3411,9 +3411,9 @@ static int __init d40_lcla_allocate(struct d40_base *base)
         * To full fill this hardware requirement without wasting 256 kb
         * we allocate pages until we get an aligned one.
         */
-       page_list = kmalloc(sizeof(unsigned long) * MAX_LCLA_ALLOC_ATTEMPTS,
-                           GFP_KERNEL);
-
+       page_list = kmalloc_array(MAX_LCLA_ALLOC_ATTEMPTS,
+                                 sizeof(*page_list),
+                                 GFP_KERNEL);
        if (!page_list) {
                ret = -ENOMEM;
                goto failure;