]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
mfd: Fix incorrect kfree(i2c) in wm8994-core i2c_driver probe
authorAxel Lin <axel.lin@gmail.com>
Mon, 9 Aug 2010 06:52:16 +0000 (14:52 +0800)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 12 Aug 2010 09:28:14 +0000 (11:28 +0200)
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/wm8994-core.c

index 69533f5ab03ebe03c0b7d681b56220d80fd1dfec..b3b2aaf89dbee70e8855c9b3124e7f04fd0aee9a 100644 (file)
@@ -497,10 +497,8 @@ static int wm8994_i2c_probe(struct i2c_client *i2c,
        struct wm8994 *wm8994;
 
        wm8994 = kzalloc(sizeof(struct wm8994), GFP_KERNEL);
-       if (wm8994 == NULL) {
-               kfree(i2c);
+       if (wm8994 == NULL)
                return -ENOMEM;
-       }
 
        i2c_set_clientdata(i2c, wm8994);
        wm8994->dev = &i2c->dev;