]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: addi_apci_1032: remove deadcode in apci1032_cos_cmdtest()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 25 Aug 2014 22:24:03 +0000 (15:24 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Aug 2014 20:20:52 +0000 (13:20 -0700)
Reported by: coverity
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_1032.c

index 1b2e7c040c9f9dc4b8e1606573596276974ea810..44080f6c887f4a79d09de379eef81fede5680d80 100644 (file)
@@ -190,9 +190,6 @@ static int apci1032_cos_cmdtest(struct comedi_device *dev,
        /* Step 2a : make sure trigger sources are unique */
        /* Step 2b : and mutually compatible */
 
-       if (err)
-               return 2;
-
        /* Step 3: check if arguments are trivially valid */
 
        err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0);
@@ -204,10 +201,9 @@ static int apci1032_cos_cmdtest(struct comedi_device *dev,
        if (err)
                return 3;
 
-       /* step 4: ignored */
+       /* Step 4: fix up any arguments */
 
-       if (err)
-               return 4;
+       /* Step 5: check channel list if it exists */
 
        return 0;
 }