]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] Fix wrong register mask in gspca/sonixj.c
authorLuiz Ramos <luizzramos@yahoo.com.br>
Fri, 15 Jul 2011 02:08:39 +0000 (23:08 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 7 Aug 2011 12:03:04 +0000 (09:03 -0300)
Hello,

When migrating from Slackware 13.1 to 13.37 (kernel 2.6.33.x to
2.6.37.6), there was some sort of regression with the external webcam
installed at the notebook (0x45:6128, SN9C325+OM6802).

In the version 2.6.37.6, the images got *very* dark, making the webcam
almost unusable, unless if used with direct sunlight.

Tracing back what happened, I concluded that changeset 0e4d413af
caused some sort of odd effects - including this - to this specific model.

Signed-off-by: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
Acked-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/gspca/sonixj.c

index 81b8a600783b575290814af47931ee5b1702ebcf..2ad757dc2e1cf72ee3a5461c2da3d60b910cb0c3 100644 (file)
@@ -2386,7 +2386,7 @@ static int sd_start(struct gspca_dev *gspca_dev)
                reg_w1(gspca_dev, 0x01, 0x22);
                msleep(100);
                reg01 = SCL_SEL_OD | S_PDN_INV;
-               reg17 &= MCK_SIZE_MASK;
+               reg17 &= ~MCK_SIZE_MASK;
                reg17 |= 0x04;          /* clock / 4 */
                break;
        }