]> git.karo-electronics.de Git - linux-beck.git/commitdiff
IB/multicast: Check ib_find_pkey() return value
authorBart Van Assche <bart.vanassche@sandisk.com>
Mon, 21 Nov 2016 18:22:17 +0000 (10:22 -0800)
committerDoug Ledford <dledford@redhat.com>
Wed, 14 Dec 2016 18:27:34 +0000 (13:27 -0500)
This patch avoids that Coverity complains about not checking the
ib_find_pkey() return value.

Fixes: commit 547af76521b3 ("IB/multicast: Report errors on multicast groups if P_key changes")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/multicast.c

index e51b739f6ea3d2e9bd6d8b776d5ea5d8e49844ba..322cb67b07a9611b658b88523eb0fc5fb988bed9 100644 (file)
@@ -518,8 +518,11 @@ static void join_handler(int status, struct ib_sa_mcmember_rec *rec,
                process_join_error(group, status);
        else {
                int mgids_changed, is_mgid0;
-               ib_find_pkey(group->port->dev->device, group->port->port_num,
-                            be16_to_cpu(rec->pkey), &pkey_index);
+
+               if (ib_find_pkey(group->port->dev->device,
+                                group->port->port_num, be16_to_cpu(rec->pkey),
+                                &pkey_index))
+                       pkey_index = MCAST_INVALID_PKEY_INDEX;
 
                spin_lock_irq(&group->port->lock);
                if (group->state == MCAST_BUSY &&