]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
backlight: lms283gf05: use devm_gpio_request_one
authorJingoo Han <jg1.han@samsung.com>
Thu, 25 Oct 2012 01:15:01 +0000 (12:15 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 30 Oct 2012 04:15:19 +0000 (15:15 +1100)
By using devm_gpio_request_one it is possible to set the direction
and initial value in one shot. Thus, using devm_gpio_request_one
can make the code simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/video/backlight/lms283gf05.c

index ea43f2254196b65982875bd420d9c16320d2457f..c452210f7aa6fb278d6ae757073210958b23ab79 100644 (file)
@@ -158,13 +158,9 @@ static int __devinit lms283gf05_probe(struct spi_device *spi)
        int ret = 0;
 
        if (pdata != NULL) {
-               ret = devm_gpio_request(&spi->dev, pdata->reset_gpio,
-                                       "LMS285GF05 RESET");
-               if (ret)
-                       return ret;
-
-               ret = gpio_direction_output(pdata->reset_gpio,
-                                               !pdata->reset_inverted);
+               ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
+                               GPIOF_DIR_OUT | !pdata->reset_inverted,
+                               "LMS285GF05 RESET");
                if (ret)
                        return ret;
        }