]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
KVM: Silence underflow warning in avic_get_physical_id_entry()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 18 May 2017 07:38:53 +0000 (10:38 +0300)
committerRadim Krčmář <rkrcmar@redhat.com>
Thu, 18 May 2017 12:53:54 +0000 (14:53 +0200)
Smatch complains that we check cap the upper bound of "index" but don't
check for negatives.  It's a false positive because "index" is never
negative.  But it's also simple enough to make it unsigned which makes
the code easier to audit.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
arch/x86/kvm/svm.c

index c27ac6923a18463751d153626f54413f9615201e..183ddb235fb48658028433d451db75d554152c54 100644 (file)
@@ -1272,7 +1272,8 @@ static void init_vmcb(struct vcpu_svm *svm)
 
 }
 
-static u64 *avic_get_physical_id_entry(struct kvm_vcpu *vcpu, int index)
+static u64 *avic_get_physical_id_entry(struct kvm_vcpu *vcpu,
+                                      unsigned int index)
 {
        u64 *avic_physical_id_table;
        struct kvm_arch *vm_data = &vcpu->kvm->arch;