]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
drm/radeon: remove FIXME comment from chipset suspend
authorChristian König <deathsimple@vodafone.de>
Thu, 5 Jul 2012 11:33:41 +0000 (13:33 +0200)
committerChristian König <deathsimple@vodafone.de>
Tue, 17 Jul 2012 08:32:28 +0000 (10:32 +0200)
For a normal suspend/resume we allready wait for
the rings to be empty, and for a suspend/reasume
in case of a lockup we REALLY don't want to wait
for anything.

Signed-off-by: Christian König <deathsimple@vodafone.de>
Reviewed-by: Jerome Glisse <jglisse@redhat.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/evergreen.c
drivers/gpu/drm/radeon/ni.c
drivers/gpu/drm/radeon/r600.c
drivers/gpu/drm/radeon/rv770.c
drivers/gpu/drm/radeon/si.c

index f716e081c813c06dbd911391d7cd4527f3e667c4..eb9a71a7a646c8ecb3d18dc3110f86b7438d8738 100644 (file)
@@ -3137,7 +3137,6 @@ int evergreen_suspend(struct radeon_device *rdev)
        struct radeon_ring *ring = &rdev->ring[RADEON_RING_TYPE_GFX_INDEX];
 
        r600_audio_fini(rdev);
-       /* FIXME: we should wait for ring to be empty */
        radeon_ib_pool_suspend(rdev);
        r600_blit_suspend(rdev);
        r700_cp_stop(rdev);
index 2366be3df0743863ad4a76f75bd7169a36da7917..32a608270d7e85aaef4b95de5fb158b5524e349c 100644 (file)
@@ -1334,7 +1334,6 @@ int cayman_resume(struct radeon_device *rdev)
 int cayman_suspend(struct radeon_device *rdev)
 {
        r600_audio_fini(rdev);
-       /* FIXME: we should wait for ring to be empty */
        radeon_ib_pool_suspend(rdev);
        radeon_vm_manager_suspend(rdev);
        r600_blit_suspend(rdev);
index 43d0c41922a5a4fbe56d96a7ec41e0fb273e3fa4..de4de2dac1600dc547083c2d47926c7b962ca26b 100644 (file)
@@ -2461,7 +2461,6 @@ int r600_suspend(struct radeon_device *rdev)
        r600_audio_fini(rdev);
        radeon_ib_pool_suspend(rdev);
        r600_blit_suspend(rdev);
-       /* FIXME: we should wait for ring to be empty */
        r600_cp_stop(rdev);
        rdev->ring[RADEON_RING_TYPE_GFX_INDEX].ready = false;
        r600_irq_suspend(rdev);
index b4f51c569c369962c2afebdee3ded9b1f71679c5..7e230f62f0faf59d483bae56f426b9887b51221d 100644 (file)
@@ -996,7 +996,6 @@ int rv770_suspend(struct radeon_device *rdev)
        r600_audio_fini(rdev);
        radeon_ib_pool_suspend(rdev);
        r600_blit_suspend(rdev);
-       /* FIXME: we should wait for ring to be empty */
        r700_cp_stop(rdev);
        rdev->ring[RADEON_RING_TYPE_GFX_INDEX].ready = false;
        r600_irq_suspend(rdev);
index 34603b3c80abbc2b64b7262d85889bcb38463e22..78c790fec63fc04cc3014f5035d05728e7170501 100644 (file)
@@ -3807,7 +3807,6 @@ int si_resume(struct radeon_device *rdev)
 
 int si_suspend(struct radeon_device *rdev)
 {
-       /* FIXME: we should wait for ring to be empty */
        radeon_ib_pool_suspend(rdev);
        radeon_vm_manager_suspend(rdev);
 #if 0