]> git.karo-electronics.de Git - linux-beck.git/commitdiff
powerpc/powernv: Don't warn on PE init if unfreeze is unsupported
authorRussell Currey <ruscur@russell.cc>
Wed, 16 Nov 2016 01:12:26 +0000 (12:12 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 22 Nov 2016 00:57:07 +0000 (11:57 +1100)
Whenever a PE is initialised in powernv, opal_pci_eeh_freeze_clear() is
called.  This is to remove any existing freeze, and has no negative side
effects if the PE is already in an unfrozen state.  On PHB backends that
don't support this operation and return OPAL_UNSUPPORTED, this creates a
scary and misleading warning message.

Skip the warning message on init if OPAL_UNSUPPORTED is returned.

As far as I'm aware, this currently only affects NPUs.

Fixes: 313483d ("powerpc/powernv: Unfreeze PE on allocation")
Signed-off-by: Russell Currey <ruscur@russell.cc>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/powernv/pci-ioda.c

index d4b33dd2d9e740d789da5768957beefcafd7f997..dcdfee0cd4f2f134f6fddeabe8130232bed4d9c6 100644 (file)
@@ -145,7 +145,7 @@ static struct pnv_ioda_pe *pnv_ioda_init_pe(struct pnv_phb *phb, int pe_no)
         */
        rc = opal_pci_eeh_freeze_clear(phb->opal_id, pe_no,
                                       OPAL_EEH_ACTION_CLEAR_FREEZE_ALL);
-       if (rc != OPAL_SUCCESS)
+       if (rc != OPAL_SUCCESS && rc != OPAL_UNSUPPORTED)
                pr_warn("%s: Error %lld unfreezing PHB#%d-PE#%d\n",
                        __func__, rc, phb->hose->global_number, pe_no);