]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
Staging: bcm: Fix assignment issue in if statement reported by checkpatch.pl.
authorKevin McKinney <klmckinney1@gmail.com>
Fri, 7 Oct 2011 22:50:12 +0000 (18:50 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 11 Oct 2011 16:18:21 +0000 (10:18 -0600)
This patch fixes an error where an assignment "="
was being used in an if statement to determine if
Firmware was downloaded. This patch removes that
assignment, and places it above the if statement.
The if statement then evaluates the status to
verify if "0" successful, or != 0 failure.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/bcm/Misc.c

index 0882e04963a22d20c9c5140d0d72b4496b4eb144..e9f29d5975186ca99a36be687a3cfdb01f7e4a9f 100644 (file)
@@ -1045,7 +1045,8 @@ int InitCardAndDownloadFirmware(PMINI_ADAPTER ps_adapter)
        }
 
        /* Download Firmare */
-       if ((status = BcmFileDownload(ps_adapter, BIN_FILE, FIRMWARE_BEGIN_ADDR))) {
+       status = BcmFileDownload(ps_adapter, BIN_FILE, FIRMWARE_BEGIN_ADDR);
+       if (status != 0) {
                BCM_DEBUG_PRINT(ps_adapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "No Firmware File is present...\n");
                goto OUT;
        }