]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
irqchip: crossbar: Remove IS_ERR_VALUE check
authorNishanth Menon <nm@ti.com>
Thu, 26 Jun 2014 07:10:24 +0000 (12:40 +0530)
committerJason Cooper <jason@lakedaemon.net>
Mon, 30 Jun 2014 19:11:21 +0000 (19:11 +0000)
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Link: https://lkml.kernel.org/r/1403766634-18543-7-git-send-email-r.sricharan@ti.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/irqchip/irq-crossbar.c

index a39cb316d2b007aa6c251f011e8bc0a05c063a91..88fbe0ff1dde19961d33051d971730a7927b39c3 100644 (file)
@@ -102,15 +102,15 @@ static int crossbar_domain_xlate(struct irq_domain *d,
                                 unsigned long *out_hwirq,
                                 unsigned int *out_type)
 {
-       unsigned long ret;
+       int ret;
 
        ret = get_prev_map_irq(intspec[1]);
-       if (!IS_ERR_VALUE(ret))
+       if (ret >= 0)
                goto found;
 
        ret = allocate_free_irq(intspec[1]);
 
-       if (IS_ERR_VALUE(ret))
+       if (ret < 0)
                return ret;
 
 found: