]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
regulator: ltc3589: Make IRQ optional
authorBernhard Walle <bernhard@bwalle.de>
Wed, 10 Feb 2016 20:37:30 +0000 (21:37 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 12 Feb 2016 22:35:00 +0000 (22:35 +0000)
It's perfectly valid to use the LTC3589 without an interrupt pin
connected to it. Currently, the driver probing fails when client->irq
is 0 (which means "no interrupt"). Don't register the interrupt
handler in that case but successfully finish the device probing instead.

Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/ltc3589.c

index 972c386b269024180e512cab2c65da0e069817c6..47bef328fb58b356c061f2a7d408da9e8a971be7 100644 (file)
@@ -520,12 +520,15 @@ static int ltc3589_probe(struct i2c_client *client,
                }
        }
 
-       ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr,
-                                       IRQF_TRIGGER_LOW | IRQF_ONESHOT,
-                                       client->name, ltc3589);
-       if (ret) {
-               dev_err(dev, "Failed to request IRQ: %d\n", ret);
-               return ret;
+       if (client->irq) {
+               ret = devm_request_threaded_irq(dev, client->irq, NULL,
+                                               ltc3589_isr,
+                                               IRQF_TRIGGER_LOW | IRQF_ONESHOT,
+                                               client->name, ltc3589);
+               if (ret) {
+                       dev_err(dev, "Failed to request IRQ: %d\n", ret);
+                       return ret;
+               }
        }
 
        return 0;