]> git.karo-electronics.de Git - linux-beck.git/commitdiff
irqchip/gic-v3-its: Narrow down Entry Size when used as a divider
authorVladimir Murzin <vladimir.murzin@arm.com>
Wed, 2 Nov 2016 11:54:04 +0000 (11:54 +0000)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 29 Nov 2016 09:14:48 +0000 (09:14 +0000)
GITS_BASER<n>'s Entry Size is much smaller than 64-bit, but when it
used as a divider it forces compiler to generate __aeabi_uldivmod if
build in 32-bit mode. So, casting it to int (like it is done in other
places) where used as a divider would give a hint to compiler that
32-bit division can be used.

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-gic-v3-its.c

index bca125e6c8e81369e480eb3c6a8e05012c67e859..312dd55dfaae8ce40eb38b4804dffcfbe467f2ae 100644 (file)
@@ -948,7 +948,7 @@ retry_baser:
        tmp = indirect ? GITS_LVL1_ENTRY_SIZE : esz;
 
        pr_info("ITS@%pa: allocated %d %s @%lx (%s, esz %d, psz %dK, shr %d)\n",
-               &its->phys_base, (int)(PAGE_ORDER_TO_SIZE(order) / tmp),
+               &its->phys_base, (int)(PAGE_ORDER_TO_SIZE(order) / (int)tmp),
                its_base_type_string[type],
                (unsigned long)virt_to_phys(base),
                indirect ? "indirect" : "flat", (int)esz,
@@ -983,7 +983,7 @@ static bool its_parse_baser_device(struct its_node *its, struct its_baser *baser
                         * which is reported by ITS hardware times lvl1 table
                         * entry size.
                         */
-                       ids -= ilog2(psz / esz);
+                       ids -= ilog2(psz / (int)esz);
                        esz = GITS_LVL1_ENTRY_SIZE;
                }
        }
@@ -998,7 +998,7 @@ static bool its_parse_baser_device(struct its_node *its, struct its_baser *baser
        new_order = max_t(u32, get_order(esz << ids), new_order);
        if (new_order >= MAX_ORDER) {
                new_order = MAX_ORDER - 1;
-               ids = ilog2(PAGE_ORDER_TO_SIZE(new_order) / esz);
+               ids = ilog2(PAGE_ORDER_TO_SIZE(new_order) / (int)esz);
                pr_warn("ITS@%pa: Device Table too large, reduce ids %u->%u\n",
                        &its->phys_base, its->device_ids, ids);
        }