]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: comedi: s526: remove unneeded check in s526_gpct_rinsn()
authorH Hartley Sweeten <hartleys@visionengravers.com>
Wed, 19 Sep 2012 22:09:57 +0000 (15:09 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Sep 2012 16:19:42 +0000 (09:19 -0700)
The comedi core validates insn->n before calling this function.
Remove the unnecessary check.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/s526.c

index 75e3e58e552ae2322d8b83b6205ba6f26cd374ce..f9f0fdaec15946939fae8b161c7642d6e23fa0a8 100644 (file)
@@ -217,11 +217,6 @@ static int s526_gpct_rinsn(struct comedi_device *dev,
        unsigned short datalow;
        unsigned short datahigh;
 
-       /*  Check if (n > 0) */
-       if (insn->n <= 0) {
-               printk(KERN_ERR "s526: INSN_READ: n should be > 0\n");
-               return -EINVAL;
-       }
        /*  Read the low word first */
        for (i = 0; i < insn->n; i++) {
                datalow = inw(dev->iobase + REG_C0L + counter_channel * 8);