]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: most: hdm-usb: use defined error codes
authorChristian Gromm <christian.gromm@microchip.com>
Fri, 9 Sep 2016 13:25:36 +0000 (15:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Sep 2016 07:47:15 +0000 (09:47 +0200)
This patch replaces return values with defined error codes to indicate
an exception.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/hdm-usb/hdm_usb.c

index da47253f0f34785e0b9561ebc300e6cbe03c9859..5d62d1bf4dc3ee7b411939802903ab323afa3db8 100644 (file)
@@ -801,17 +801,17 @@ static int hdm_update_netinfo(struct most_dev *mdev)
        if (!is_valid_ether_addr(mdev->hw_addr)) {
                if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_HI, &hi) < 0) {
                        dev_err(dev, "Vendor request \"hw_addr_hi\" failed\n");
-                       return -1;
+                       return -EFAULT;
                }
 
                if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_MI, &mi) < 0) {
                        dev_err(dev, "Vendor request \"hw_addr_mid\" failed\n");
-                       return -1;
+                       return -EFAULT;
                }
 
                if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_LO, &lo) < 0) {
                        dev_err(dev, "Vendor request \"hw_addr_low\" failed\n");
-                       return -1;
+                       return -EFAULT;
                }
 
                mutex_lock(&mdev->io_mutex);
@@ -826,7 +826,7 @@ static int hdm_update_netinfo(struct most_dev *mdev)
 
        if (drci_rd_reg(usb_device, DRCI_REG_NI_STATE, &link) < 0) {
                dev_err(dev, "Vendor request \"link status\" failed\n");
-               return -1;
+               return -EFAULT;
        }
 
        mutex_lock(&mdev->io_mutex);
@@ -1116,7 +1116,7 @@ static ssize_t store_value(struct most_dci_obj *dci_obj,
                reg_addr = DRCI_REG_BASE + DRCI_COMMAND + ep * 16;
                val = 1;
        } else
-               return -EIO;
+               return -EFAULT;
 
        err = drci_wr_reg(dci_obj->usb_device, reg_addr, val);
        if (err < 0)