]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
x86, nops: Missing break resulting in incorrect selection on Intel
authorAlan Cox <alan@linux.intel.com>
Wed, 25 Jul 2012 15:28:19 +0000 (16:28 +0100)
committerH. Peter Anvin <hpa@zytor.com>
Wed, 25 Jul 2012 15:35:38 +0000 (08:35 -0700)
The Intel case falls through into the generic case which then changes
the values.  For cases like the P6 it doesn't do the right thing so
this seems to be a screwup.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/n/tip-lww2uirad4skzjlmrm0vru8o@git.kernel.org
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: <stable@vger.kernel.org>
arch/x86/kernel/alternative.c

index 1f84794f0759327c387d602cddccb3d479188f92..73ef56c5a8b373bccbe8451746bbf67e90808dc3 100644 (file)
@@ -219,7 +219,7 @@ void __init arch_init_ideal_nops(void)
                        ideal_nops = intel_nops;
 #endif
                }
-
+               break;
        default:
 #ifdef CONFIG_X86_64
                ideal_nops = k8_nops;