]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ipvs: remove unnecessary assignment in __ip_vs_get_out_rt
authorAlex Gartrell <agartrell@fb.com>
Mon, 6 Oct 2014 20:30:08 +0000 (13:30 -0700)
committerSimon Horman <simon.horman@netronome.com>
Tue, 28 Oct 2014 00:50:06 +0000 (09:50 +0900)
It is a precondition of the function that daddr be equal to dest->addr.ip
if dest is non-NULL, so this additional assignment is just confusing for
stupid engineers like me.

Signed-off-by: Alex Gartrell <agartrell@fb.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
net/netfilter/ipvs/ip_vs_xmit.c

index 91f17c1eb8a20c0226e01c68e255acf118a6a4d0..5efa59792505eae78090f24dd17e579449db2bce 100644 (file)
@@ -293,7 +293,6 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest,
                                  &dest->addr.ip, &dest_dst->dst_saddr.ip,
                                  atomic_read(&rt->dst.__refcnt));
                }
-               daddr = dest->addr.ip;
                if (ret_saddr)
                        *ret_saddr = dest_dst->dst_saddr.ip;
        } else {