]> git.karo-electronics.de Git - linux-beck.git/commitdiff
Staging: comedi: fix printk issue in cb_pcidas64.c
authorRavishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Mon, 12 Dec 2011 05:19:35 +0000 (10:49 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 14 Dec 2011 00:37:11 +0000 (16:37 -0800)
This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels> and Removed unnecessary
printk statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/comedi/drivers/cb_pcidas64.c

index 1e324198996cff1c57f22c34117e9497ac8ca689..b68c5874b2e551f4627a2899e70fd2bab430e132 100644 (file)
@@ -1739,8 +1739,6 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
        uint32_t local_range, local_decode;
        int retval;
 
-       printk("comedi%d: cb_pcidas64\n", dev->minor);
-
 /*
  * Allocate the private structure area.
  */
@@ -1781,12 +1779,11 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
                return -EIO;
        }
 
-       printk("Found %s on bus %i, slot %i\n", board(dev)->name,
-              pcidev->bus->number, PCI_SLOT(pcidev->devfn));
+       dev_dbg(dev->hw_dev, "Found %s on bus %i, slot %i\n", board(dev)->name,
+               pcidev->bus->number, PCI_SLOT(pcidev->devfn));
 
        if (comedi_pci_enable(pcidev, driver_cb_pcidas.driver_name)) {
-               printk(KERN_WARNING
-                      " failed to enable PCI device and request regions\n");
+               dev_warn(dev->hw_dev, "failed to enable PCI device and request regions\n");
                return -EIO;
        }
        pci_set_master(pcidev);
@@ -1814,7 +1811,7 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
 
        if (!priv(dev)->plx9080_iobase || !priv(dev)->main_iobase
            || !priv(dev)->dio_counter_iobase) {
-               printk(" failed to remap io memory\n");
+               dev_warn(dev->hw_dev, "failed to remap io memory\n");
                return -ENOMEM;
        }
 
@@ -1850,17 +1847,19 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
 
        priv(dev)->hw_revision =
            hw_revision(dev, readw(priv(dev)->main_iobase + HW_STATUS_REG));
-       printk(" stc hardware revision %i\n", priv(dev)->hw_revision);
+       dev_dbg(dev->hw_dev, "stc hardware revision %i\n",
+               priv(dev)->hw_revision);
        init_plx9080(dev);
        init_stc_registers(dev);
        /*  get irq */
        if (request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED,
                        "cb_pcidas64", dev)) {
-               printk(" unable to allocate irq %u\n", pcidev->irq);
+               dev_dbg(dev->hw_dev, "unable to allocate irq %u\n",
+                       pcidev->irq);
                return -EINVAL;
        }
        dev->irq = pcidev->irq;
-       printk(" irq %u\n", dev->irq);
+       dev_dbg(dev->hw_dev, "irq %u\n", dev->irq);
 
        retval = setup_subdevices(dev);
        if (retval < 0)