]> git.karo-electronics.de Git - linux-beck.git/commitdiff
crypto: powerpc - replace memset by memzero_explicit
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 30 Nov 2014 17:03:47 +0000 (18:03 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 2 Dec 2014 14:55:50 +0000 (22:55 +0800)
Memset on a local variable may be removed when it is called just before the
variable goes out of scope.  Using memzero_explicit defeats this
optimization.  A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
type T;
@@

{
... when any
T x[...];
... when any
    when exists
- memset
+ memzero_explicit
  (x,
-0,
  ...)
... when != x
    when strict
}
// </smpl>

This change was suggested by Daniel Borkmann <dborkman@redhat.com>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/powerpc/crypto/sha1.c

index 0f88c7b411196beeb3eb9d717ea24bf0cc958f00..d3feba5a275f6465fa46b850ed57cb688bd834ea 100644 (file)
@@ -66,7 +66,7 @@ static int sha1_update(struct shash_desc *desc, const u8 *data,
                        src = data + done;
                } while (done + 63 < len);
 
-               memset(temp, 0, sizeof(temp));
+               memzero_explicit(temp, sizeof(temp));
                partial = 0;
        }
        memcpy(sctx->buffer + partial, src, len - done);