]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
spi: fsl: Use kmalloc_array() in of_fsl_spi_get_chipselects()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 13 Jan 2017 12:37:25 +0000 (13:37 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 17 Jan 2017 18:27:38 +0000 (18:27 +0000)
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-spi.c

index 8b290d9d7935044640da36688e82fd01e90bf114..9873d39d1a95c99324f960ec2323a9c4ce773061 100644 (file)
@@ -727,7 +727,8 @@ static int of_fsl_spi_get_chipselects(struct device *dev)
                return 0;
        }
 
-       pinfo->gpios = kmalloc(ngpios * sizeof(*pinfo->gpios), GFP_KERNEL);
+       pinfo->gpios = kmalloc_array(ngpios, sizeof(*pinfo->gpios),
+                                    GFP_KERNEL);
        if (!pinfo->gpios)
                return -ENOMEM;
        memset(pinfo->gpios, -1, ngpios * sizeof(*pinfo->gpios));